Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main with all changes #29

Merged
merged 108 commits into from
Jan 22, 2025
Merged

Update main with all changes #29

merged 108 commits into from
Jan 22, 2025

Conversation

manojkgorle
Copy link
Member

No description provided.

@manojkgorle manojkgorle requested a review from mtgnoah January 7, 2025 13:41
actions/consts.go Show resolved Hide resolved
actions/epoch_exit.go Show resolved Hide resolved
actions/rollup_register.go Show resolved Hide resolved
actions/rollup_register.go Outdated Show resolved Hide resolved
"github.com/AnomalyFi/nodekit-seq/storage"
)

func isWhiteListed(rules chain.Rules, actor codec.Address) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments above all the functions in this file to explain them

arcadia.md Outdated
@@ -0,0 +1,47 @@
# Arcadia

Arcadia facilitates the Shared Block Production on The Composable Network for participating Rollups. Block Production on Arcadia is divided into 12s(6 SEQ blocks) Epochs with a single block builder building blocks for all the participating rollups in that Epoch. Winning block builder is selected through a Ahead Of Time Auction on Arcadia. Rollup blocks are built as chunks and preconfed by validators. All txs in preconfed chunks will be included in SEQ blocks in later time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix all grammar mistakes with arcadia switching to Arcadia throughout this page

for _, act := range tx.Actions {
switch act.(type) {
case *actions.Transfer:
c.metrics.transfer.Inc()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the other actions here

@@ -46,26 +42,7 @@ func newMetrics(gatherer ametrics.MultiGatherer) (*metrics, error) {
Name: "transfer",
Help: "number of transfer actions",
}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the other actions here

rpc/jsonrpc_server.go Outdated Show resolved Hide resolved
@bianyuanop
Copy link
Contributor

LGTM

Copy link

@rikoeldon rikoeldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtgnoah mtgnoah merged commit 14b2064 into main Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants